search

JuliaDatabases / DBAPI.jl

A new database interface proposal
Other
12 stars 12 forks source link

Tests fail on v0.5 #9

Closed ranjanan closed 7 years ago

ranjanan commented 8 years ago

The tests in the Arrays category fail with the following error trace for each failed fact:

ERROR: MethodError: no method matching length(::DBAPI.ArrayInterfaces.ColumnarArrayRowIterator) # Could be ColumnIterator too
Closest candidates are:
  length(::SimpleVector) at essentials.jl:168
  length(::Base.MethodList) at reflection.jl:256
  length(::MethodTable) at reflection.jl:322
  ...
 in _similar_for at ./array.jl:262 [inlined]
 in _collect at ./array.jl:277 [inlined]
 in collect(::DBAPI.ArrayInterfaces.ColumnarArrayRowIterator) at ./array.jl:273

This isn't in an issue on v0.4, and tests pass there.

I checked the various methods defined for length and I found this one method that got defined in v0.4 but not in v0.5

length(cursor::DBAPI.ArrayInterfaces.ColumnarArrayCursor) at /Users/ranjan/.julia/v0.4/DBAPI/src/arrays.jl:107

I wonder if this is causing the issue.

ranjanan commented 8 years ago

cc: @mdpradeep

iamed2 commented 8 years ago

Tracked it down; looks like collect requires length on 0.5 but not on 0.4. Might have something to do with some traits?