Closed ExpandingMan closed 4 years ago
ExpandingMan
commented
4 years ago Ah, cool, I'll remove the deprecations and then we should be good to go... that is, assuming there's not stuff in the MS SQL tests that's vital (there really shouldn't be).
codecov-io
commented
4 years ago Merging #261 into master will decrease coverage by
5.08%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 57.17% 52.08% -5.09%
==========================================
Files 6 6
Lines 523 576 +53
==========================================
+ Hits 299 300 +1
- Misses 224 276 +52 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/API.jl | 21.35% <0.00%> (-13.02%) |
:arrow_down: |
| src/types.jl | 50.00% <0.00%> (-1.86%) |
:arrow_down: |
| src/Query.jl | 72.58% <0.00%> (-1.09%) |
:arrow_down: |
| src/Sink.jl | 0.00% <0.00%> (ø) |
|
| src/sqlreplmode.jl | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b8271f1...4c55107. Read the comment docs.
ExpandingMan
commented
4 years ago Oops, I had broken a test.
I've now restored the compat section in Project.toml and bumped the package version.
quinnj
commented
4 years ago Sorry for the slowness here; due to #263 being merged, I created a separate v0.9 branch and backported these commits to it and tagged a new release.
quinnj
commented
4 years ago ExpandingMan
commented
4 years ago Wow, glad the big rewrite was merged already, looking forward to checking it out! Yeah, it's good of you to do backports, I probably wouldn't have even bothered 😄
I don't really think this is going to work, because I was only able to do the postgres tests locally and they're not all the same, but I wanted to see what would happen.
I expect that the DataFrames update is fine and won't break anything since this package only uses constructors, but I imagine that the new CategoricalArrays (which DataFrames depends on) will break things spectacularly.
I know @quinnj is working on a real overhaul of this package, but it's currently blocking dataframes for me and I thought it might not actually be difficult to get this working on modern packages (certainly true of DataFrames, likely not of CategoricalArrays).
Anyway, let's see what travis looks like... does this stuff even really get tested on travis? I guess we're about to find out...