search

JuliaDatabases / ODBC.jl

An ODBC interface for the Julia programming language
https://odbc.juliadatabases.org/stable
Other
106 stars 63 forks source link

Allow a fix for #249 #267

Closed quinnj closed 4 years ago

quinnj commented 4 years ago

From some research discovered here and in the Netezza ODBC documentation here, the Netezza ODBC driver, by default, has a 'Prefetch Count' setting, defaulting to 256, that limits the # of rows that will return for a resultset. It's unclear whether you can set this number to -1 or some really large integer # (4 trillion or so) and if that would work (or try to consume that much memory by pre-allocating?).

In any case, RODBC has a setting believeNRows, so we introduce a similar (though IMO better named) keyword argument ignore_driver_row_count, which, when set to true, will force the result handling code to iterate rows with no known length, which is the setting we want when we're unable to pre-allocate full columns.

codecov-commenter commented 4 years ago

Codecov Report

Merging #267 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files           5        5           
  Lines         651      651           
=======================================
  Hits          470      470           
  Misses        181      181
Impacted Files Coverage Δ
src/API.jl 57.65% <ø> (ø)
src/dbinterface.jl 89.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4dd7ba...fc526e1. Read the comment docs.