Julia v0.4 compatibility changes.

JuliaDatabases / PostgreSQL.jl

DEPRECATED: use LibPQ.jl instead

https://github.com/invenia/LibPQ.jl

Other

60 stars 39 forks source link

Julia v0.4 compatibility changes. #17

Closed omus closed 9 years ago

omus commented 9 years ago

Tested changes on Julia 0.3.10 and 0.4.0-dev+5629.

iamed2 commented 9 years ago

@omus https://travis-ci.org/JuliaDB/PostgreSQL.jl/jobs/69471749

Segfaults consistently on 0.4

omus commented 9 years ago

I cannot reproduce this segfault. I'll note that I didn't change anything specific to the DB connection so I expect that this issue was present prior to my changes. Can you attempt to re-run Travis on the latest version of Julia for this PR and for the latest PostgreSQL master?

iamed2 commented 9 years ago

@omus try changing the postgresql apt package to postgresql-9.4. Pushing will trigger a rebuild.

omus commented 9 years ago

Inspecting the travis log again I noticed that the test cases were running via:

julia --check-bounds=yes --code-coverage=user --inline=no --color=no ~/.julia/v0.4/PostgreSQL/test/runtests.jl

Which does produce a segfault on my local system. It appears the issue is --inline=no. I'll try to determine why this parameter is causing issues.

omus commented 9 years ago

@iamed2 I believe you'll need to investigate. It appears that using any libpq function that modifies the internals of a Ptr such as PQfinish, PQclear, or PQfreemem will all generate a segfault when running the tests.

iamed2 commented 9 years ago

Please edit PR to compare against compat