search

JuliaDebug / Cthulhu.jl

The slow descent into madness
MIT License
657 stars 41 forks source link

changes to adapt to compressed line table format #526

Closed vtjnash closed 7 months ago

vtjnash commented 10 months ago

This contains some updates needed to keep working with the optimized debuginfo format (https://github.com/JuliaLang/julia/pull/52415).

Also needs https://github.com/JuliaDebug/JuliaInterpreter.jl/pull/606

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f3dd6cd) to head (f99d97c).

Files Patch % Lines
src/reflection.jl 0.00% 14 Missing :warning:
src/interpreter.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #526 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 9 9 Lines 1541 1545 +4 ====================================== - Misses 1541 1545 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aviatesk commented 7 months ago

TypedSyntax test is failing badly...

aviatesk commented 7 months ago

I adjusted the TypedSyntax update so now the number of failing tests matches what we're seeing with v1.11-nightly. I'm going to push ahead with this as it stands to keep working on other packages. I aim to implement more conservative and safer changes in the near future.

aviatesk commented 7 months ago

Ok, Cthulhu CI is green on nightly. I will go ahead and merge.