JuliaDebug / JuliaInterpreter.jl

Interpreter for Julia code
Other
158 stars 33 forks source link

RFC: upper-bound julia version in [compat] #586

Closed timholy closed 10 months ago

timholy commented 10 months ago

In practice, JuliaInterpreter is frequently broken by internal changes in Julia. As suggested on discourse, perhaps we should consider upper-bounding the Julia version.

This is RFC because I'm not certain this really fixes problems. What this presumably means is that if you have an old Project/Manifest lying around, you upgrade your Julia version, and then activate the project, you'll immediately get a compatibility issue. If you then update the project, often you'll get new versions of everything. So it seems that we're still in a mode where we ensure that new releases of packages work with new versions of Julia, but not fixing the complaint (in that discourse thread) that old package versions don't always work with new Julia releases.

Fundamentally, though, practical experience makes me skeptical that the current version of JuliaInterpreter can be trusted to work on, say, Julia 1.14. That alone seems to argue that bounding makes sense, even if it just changes the kind of error. A possible downside is that you're trading an error that you think is likely to one that is guaranteed.

codecov[bot] commented 10 months ago

Codecov Report

Merging #586 (f4cba79) into master (6da0b26) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   86.63%   86.62%   -0.02%     
==========================================
  Files          12       12              
  Lines        2537     2534       -3     
==========================================
- Hits         2198     2195       -3     
  Misses        339      339              

see 1 file with indirect coverage changes

timholy commented 10 months ago

Since @KristofferC is the Pkg guru and he gave this a thumbs-down, that's enough for me.