search

JuliaDebug / JuliaInterpreter.jl

Interpreter for Julia code
Other
158 stars 33 forks source link

investigate segfaults on CI #594

Closed simeonschaub closed 7 months ago

simeonschaub commented 8 months ago

The segfaults on CI seem to point to these two tests in particular. Let's see if disabling them fixes CI or whether that might have just been a red herring

codecov[bot] commented 8 months ago

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (7beca92) 86.54% compared to head (6070f13) 82.26%.

Files Patch % Lines
src/builtins.jl 11.25% 71 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #594 +/- ## ========================================== - Coverage 86.54% 82.26% -4.29% ========================================== Files 12 12 Lines 2542 2458 -84 ========================================== - Hits 2200 2022 -178 - Misses 342 436 +94 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simeonschaub commented 8 months ago

Well, that certainly answers the question... 😅

aviatesk commented 8 months ago

😱

simeonschaub commented 7 months ago

Hmm, at least nightly doesn't segfault anymore, the tests just fail... :thinking:

aviatesk commented 7 months ago

How would you like to proceed with this issue? I'm of the view that for healthy development, it's acceptable to disable tests that are challenging to correct at the moment. My preference is to focus on restoring the CI as a first step.

simeonschaub commented 7 months ago

Yeah, unfortunately this PR showed that the issues ran deeper than just a single failing test. Wondering wether the segfaults might have to do with https://github.com/JuliaDebug/JuliaInterpreter.jl/issues/591?

aviatesk commented 7 months ago

Yeah, I will take a look on it later today.