JuliaDebug / JuliaInterpreter.jl

Interpreter for Julia code
Other
158 stars 33 forks source link

Version 0.9.27 breaks older Revise versions #602

Open fingolfin opened 7 months ago

fingolfin commented 7 months ago

Due to a bug in current Revise.jl versions, I am still using Revise 3.4.0.

But this got broken by the updated of JuliaInterpreter to 0.9.27:

julia> using Revise
[ Info: Precompiling Revise [295af30f-e4ad-537b-8983-00126c2a3abe]
ERROR: LoadError: UndefVarError: `is_GotoIfNot` not defined
Stacktrace:
 [1] include
   @ ./Base.jl:457 [inlined]
 [2] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2049
 [3] top-level scope
   @ stdin:3
in expression starting at /Users/mhorn/.julia/packages/Revise/do2nH/src/Revise.jl:1
in expression starting at stdin:3
ERROR: Failed to precompile Revise [295af30f-e4ad-537b-8983-00126c2a3abe] to "/Users/mhorn/.julia/compiled/v1.9/Revise/jl_bcJhkz".
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
   @ Base ./loading.jl:2294
 [3] compilecache
   @ ./loading.jl:2167 [inlined]
 [4] _require(pkg::Base.PkgId, env::String)
   @ Base ./loading.jl:1805
 [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
   @ Base ./loading.jl:1660
 [6] macro expansion
   @ ./loading.jl:1648 [inlined]
 [7] macro expansion
   @ ./lock.jl:267 [inlined]
 [8] require(into::Module, mod::Symbol)
   @ Base ./loading.jl:1611

For now I solved this by pinning JuliaInterpreter to 0.9.26.

But I wonder if perhaps you would consider to yank 0.9.27 and re-release it as 0.10.0?

aviatesk commented 5 months ago

Sorry for being late to reply, but is this still issue for you?

visr commented 4 months ago

I guess this is not an issue anymore since the downstream packages have adapted. I just fixed part of that in vscode-julia, https://github.com/julia-vscode/julia-vscode/pull/3541.