search

JuliaDebug / JuliaInterpreter.jl

Interpreter for Julia code
Other
158 stars 33 forks source link

implement support for `current_scope` #605

Closed aviatesk closed 6 months ago

Keno commented 6 months ago

Seems reasonable, but it feels like there needs to be something that actually reflects the shadow copy of the current scope here into the runtime upon calling a native function. Not sure if that's here or in Debugger.jl

codecov[bot] commented 6 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (580b95c) 85.64% compared to head (2d026eb) 85.38%.

:exclamation: Current head 2d026eb differs from pull request most recent head 9ce455e. Consider uploading reports for the commit 9ce455e to get more accurate results

Files Patch % Lines
src/builtins.jl 30.00% 7 Missing :warning:
src/interpret.jl 16.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #605 +/- ## ========================================== - Coverage 85.64% 85.38% -0.26% ========================================== Files 12 12 Lines 2515 2525 +10 ========================================== + Hits 2154 2156 +2 - Misses 361 369 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aviatesk commented 6 months ago

This PR impacts the nightly CI only, although the nightly CI are all failing due to unrelated issues to this PR, primarily due to issues #610 and possibly #591. Despite the failures, the tests added in this PR have been successfully executed on my local nightly build. Considering this PR also resolves the Check builtins.jl CI issue, I'd like to move forward with it.