search

JuliaDebug / JuliaInterpreter.jl

Interpreter for Julia code
Other
158 stars 33 forks source link

Fix revise#718 #609

Closed timholy closed 6 months ago

timholy commented 6 months ago

This is a very minimal fix, reasoning that global annotations are common at toplevel but local ones are not. When I fixed #427, there was no good reason to avoid splitting on global, I don't know why I did that.

We might someday want to rewrite ExprSplitter more extensively, but that would likely be a breaking change.

Fixes https://github.com/timholy/Revise.jl/issues/718 Also adds nested docstring test

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0089e4b) 83.38% compared to head (c15f7e8) 83.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #609 +/- ## ======================================= Coverage 83.38% 83.38% ======================================= Files 12 12 Lines 2378 2378 ======================================= Hits 1983 1983 Misses 395 395 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timholy commented 6 months ago

Wow, segfault or ReadOnlyMemoryError on all three Julia 1.10s. It's common locally, too, although if I run the tests enough times I get this to pass. Clearly we're going to have to fix the segfaults. I've never gotten rr working on my WSL instance so I can't promise it will be soon.

timholy commented 6 months ago

I notice there are a bunch of commits since the most recent release. Many of these commits are recent, suggesting lots of development effort lately. For that reason I won't tag a new release (I'm uncertain if we're midstream in a bunch of improvements), but certainly a new release will be welcome whenever it's a good time.

aviatesk commented 6 months ago

Let's go ahead with a new release. Ideally, fixing the segfault and finishing #605 would be great, but as they might require more time and aren't supported in the current release anyway, so they shouldn't delay the new release. Above all, it's a significant benefit that we can close the Revise issue with the new release.

timholy commented 6 months ago

Aww, Revise is all green and pretty again (except nightly). Thanks for the release!