JuliaDecisionFocusedLearning / ImplicitDifferentiation.jl

Automatic differentiation of implicit functions
https://juliadecisionfocusedlearning.github.io/ImplicitDifferentiation.jl/
MIT License
122 stars 7 forks source link

Add docs for memoization #132

Closed sfalmo closed 5 months ago

sfalmo commented 6 months ago

Add documentation in FAQ as discussed in #131.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.34%. Comparing base (2e377d5) to head (bfd5414).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ======================================= Coverage 97.34% 97.34% ======================================= Files 9 9 Lines 188 188 ======================================= Hits 183 183 Misses 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sfalmo commented 6 months ago

How funny, v0.15.11 of ComponentArrays.jl, which was released 2h ago, now provides an rrule that makes Zygote work. Hence this @test_broken check actually passes. I think we should address this in a new PR.

gdalle commented 6 months ago

Wow, that's fun indeed ^^ wanna do the honors?

gdalle commented 6 months ago

Ok we're good, I also did a bit of cleanup. Wanna merge main into this?

gdalle commented 5 months ago

The diff is huge now, can you merge main into this branch to highlight only your changes to the docs?

sfalmo commented 5 months ago

Sorry, did some weird rebasing by accident. Now it should be fine.