Compatibility with Julia 1.6

JuliaDecisionFocusedLearning / InferOpt.jl

Combinatorial optimization layers for machine learning pipelines

https://juliadecisionfocusedlearning.github.io/InferOpt.jl/

MIT License

113 stars 4 forks source link

Compatibility with Julia 1.6 #26

Open gdalle opened 2 years ago

gdalle commented 2 years ago

It would be nice to be compatible with Julia's Long Term Support (LTS) version 1.6. I think the main obstacle at the moment is the use of the destructuring syntax (; a, b) = x, which was introduced in Julia 1.7. Shouldn't be hard to fix, and the test CI needs to be updated too.

gdalle commented 1 year ago

Use https://github.com/devmotion/SimpleUnPack.jl

BatyLeo commented 1 year ago

Is it really useful to be compatible with 1.6 ?

gdalle commented 1 year ago

Is it really useful to be compatible with 1.6 ?

Debatable. The main reason is that it is the current LTS version, which means some careful companies might only want to use this one for fear of running into issues