JuliaDecisionFocusedLearning / InferOpt.jl

Combinatorial optimization layers for machine learning pipelines
https://juliadecisionfocusedlearning.github.io/InferOpt.jl/
MIT License
114 stars 4 forks source link

Correct rrule for perturbed #75

Closed gdalle closed 1 year ago

gdalle commented 1 year ago

Fix #74

Compression won't work with perturbed layers because we need all the Z samples for the rrule

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 24.00% and project coverage change: -0.36 :warning:

Comparison is base (b9f84b9) 80.57% compared to head (d6784c4) 80.22%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== - Coverage 80.57% 80.22% -0.36% ========================================== Files 19 19 Lines 345 349 +4 ========================================== + Hits 278 280 +2 - Misses 67 69 +2 ``` | [Impacted Files](https://app.codecov.io/gh/axelparmentier/InferOpt.jl/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/utils/probability\_distribution.jl](https://app.codecov.io/gh/axelparmentier/InferOpt.jl/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3V0aWxzL3Byb2JhYmlsaXR5X2Rpc3RyaWJ1dGlvbi5qbA==) | `36.58% <0.00%> (ø)` | | | [src/perturbed/additive.jl](https://app.codecov.io/gh/axelparmentier/InferOpt.jl/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BlcnR1cmJlZC9hZGRpdGl2ZS5qbA==) | `83.33% <75.00%> (-3.04%)` | :arrow_down: | | [src/perturbed/multiplicative.jl](https://app.codecov.io/gh/axelparmentier/InferOpt.jl/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BlcnR1cmJlZC9tdWx0aXBsaWNhdGl2ZS5qbA==) | `83.33% <75.00%> (-3.04%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.