search

JuliaDiff / AbstractDifferentiation.jl

An abstract interface for automatic differentiation.
https://juliadiff.org/AbstractDifferentiation.jl/
MIT License
135 stars 18 forks source link

Fix tuple behavior in pushforward_function and pullback_function #100

Closed gdalle closed 1 year ago

gdalle commented 1 year ago

Fix #99

Needs tests to ensure non-regression

Probably useless after #93 but could be merged into it

Tried to make the code a bit more readable by avoiding chained anonymous functions

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.81% :tada:

Comparison is base (041d760) 84.25% compared to head (30644c4) 85.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== + Coverage 84.25% 85.07% +0.81% ========================================== Files 8 8 Lines 470 469 -1 ========================================== + Hits 396 399 +3 + Misses 74 70 -4 ``` | [Files Changed](https://app.codecov.io/gh/JuliaDiff/AbstractDifferentiation.jl/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/AbstractDifferentiation.jl](https://app.codecov.io/gh/JuliaDiff/AbstractDifferentiation.jl/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL0Fic3RyYWN0RGlmZmVyZW50aWF0aW9uLmps) | `80.72% <93.33%> (+1.06%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohamed82008 commented 1 year ago

Closing this in favour of #102.