search

JuliaDiff / AbstractDifferentiation.jl

An abstract interface for automatic differentiation.
https://juliadiff.org/AbstractDifferentiation.jl/
MIT License
135 stars 18 forks source link

Fix #99 #102

Closed mohamed82008 closed 11 months ago

mohamed82008 commented 1 year ago

This PR fixes #99 and supersedes #100.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.58% :warning:

Comparison is base (f9517dc) 84.25% compared to head (4ec5450) 83.68%.

:exclamation: Current head 4ec5450 differs from pull request most recent head 7f53a38. Consider uploading reports for the commit 7f53a38 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ========================================== - Coverage 84.25% 83.68% -0.58% ========================================== Files 8 8 Lines 470 478 +8 ========================================== + Hits 396 400 +4 - Misses 74 78 +4 ``` | [Files Changed](https://app.codecov.io/gh/JuliaDiff/AbstractDifferentiation.jl/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/AbstractDifferentiation.jl](https://app.codecov.io/gh/JuliaDiff/AbstractDifferentiation.jl/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL0Fic3RyYWN0RGlmZmVyZW50aWF0aW9uLmps) | `79.01% <60.00%> (-0.65%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 11 months ago

I think this will be superseded by #53 if we can manage it