Closed gdalle closed 11 months ago
I think this might require more discussion and changes in the code, so I'd suggest leaving it for a separate PR.
I agree, but still I think leaving the page in the docs makes sense, if only to show readers that there are two aspects to the package and only one is documented yet.
Patch and project coverage have no change.
Comparison is base (
df50a8d
) 82.94% compared to head (c2014ac
) 82.94%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks for the huge merge conflict from JuliaFormatter 🤣
Ooops, sorry 😬
I encountered a weird behavior where the cross-references in the docs wouldn't work with the AD
shortcut for AbstractDifferentiation
, even though I imported it as such in docs/make.jl
. This explains the workflow failure on the penultimate commit. Do you think it's a Documenter bug or just me asking too much?
Generally, I think it's not too bad (maybe even clearer?) if the docs do only use the user-defined convenience alias in the examples.
I do agree, but I don't think it should block this PR.
So maybe one option would be to set the current module to Main.
I looked around and I didn't find a way to do that in the kwargs of Documenter.makedocs
, are you aware of one?
I would proceed with caution though, cause it might trigger other unexpected behaviors. Maybe it is actually easier to define const AD = AbstractDifferentiation
within the module itself, without exporting it?
Maybe it is actually easier to define const AD = AbstractDifferentiation within the module itself, without exporting it?
This was done initially but caused some problems (would have to look it up though). Generally, my gut feeling is that it is cleaner and easier to let users decide whether and what abbreviation they want to use. import ... as ...
was designed for that use case and seems sufficiently concise IMO.
Thanks for the thorough review!
README content is not discoverable by users in the REPL. This PR fixes that by moving the function descriptions to docstrings, and updating the documentation website to reflect that.
docs/Manifest.toml
and activate CompatHelper ondocs/Project.toml
@primitive
does and how to use itNo actual Julia code has been changed except in
docs/make.jl