search

JuliaDiff / AbstractDifferentiation.jl

An abstract interface for automatic differentiation.
https://juliadiff.org/AbstractDifferentiation.jl/
MIT License
135 stars 18 forks source link

Fix docs #115

Closed devmotion closed 11 months ago

devmotion commented 11 months ago

The PR tries to fix the build failure on the master branch (see https://github.com/JuliaDiff/AbstractDifferentiation.jl/pull/112#issuecomment-1749687780).

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (0559f3b) 82.94% compared to head (e50e525) 82.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #115 +/- ## ======================================= Coverage 82.94% 82.94% ======================================= Files 8 8 Lines 428 428 ======================================= Hits 355 355 Misses 73 73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 11 months ago

I think we should just keep 0.6 since the docs will no longer be accurate for 0.5? Or remove the project entry altogether as you suggested, honestly it's fine either way. It's too small an issue to waste time debating it

devmotion commented 11 months ago

Just removing it won't play nicely with CompatHelper (and without any compat entries at all docs might break at any time, as happened in multiple repos with Documenter 1). So I guess the best is to just use 0.6.

devmotion commented 11 months ago

Ah wait, that also won't work with XompatHelper - it will reopen PRs for 0.5. So 0.5, 0.6 is the best option I think.