search

JuliaDiff / AbstractDifferentiation.jl

An abstract interface for automatic differentiation.
https://juliadiff.org/AbstractDifferentiation.jl/
MIT License
137 stars 18 forks source link

Run CI on tags #118

Closed gdalle closed 1 year ago

gdalle commented 1 year ago

Hopefully fixes the lack of a stable docs build

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (d36bb00) 82.94% compared to head (45fbe16) 82.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## ======================================= Coverage 82.94% 82.94% ======================================= Files 8 8 Lines 428 428 ======================================= Hits 355 355 Misses 73 73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devmotion commented 1 year ago

Why don't we have a separate Docs.yml action? There's no need to rerun CI tests on tags, we only need the docs.

gdalle commented 1 year ago

I guess it doesn't hurt to prove that the tests pass specifically for the tag you want. Otherwise if you wanna check you have to go back in time and look for the tests of the associated commit. But I don't feel strongly about either option

devmotion commented 1 year ago

I think it's sufficient to run CI once for every commit. If you go to a tag, you also end up with the commit with the CI runs next to it.

gdalle commented 1 year ago

Alright, I'll split out a docs workflow tomorrow