Closed devmotion closed 1 year ago
Patch coverage: 75.00
% and project coverage change: -0.12
:warning:
Comparison is base (
19ce815
) 84.36% compared to head (848ee38
) 84.25%.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I made the fix more modular in https://github.com/JuliaDiff/AbstractDifferentiation.jl/pull/77/commits/848ee3847c364bd95f4a0d6a57c7f6787cb3d43f, to avoid code duplication and make it easy to apply similar fixes for other AD backends if needed.
Well, that eliminates my only substantive point in https://github.com/JuliaDiff/AbstractDifferentiation.jl/pull/76#issuecomment-1453695860. As the adage goes, the fastest way to get something done is to do it wrong and get someone to correct it for you :laughing:
That is, you approve this PR? 🙂
I trust your Zygote expertise 🙂
Alternative to #76 that I had in mind when writing https://github.com/JuliaDiff/AbstractDifferentiation.jl/pull/76#pullrequestreview-1323649955.
In contrast to #76, with this PR
ZygoteBackend
would still be aReverseRuleConfigBackend
, and hence the behaviour ofZygoteBackend
andReverseRuleConfigBackend(Zygote.ZygoteRuleConfig())
would not differ.Fixes #69. Closes #70. Closes #76.