Closed sethaxen closed 4 years ago
Happy to help out anywhere that it would be useful, but you're probably the best placed to deal with these.
Update Zygote's adjoints to stop conjugating to/from ChainRules (breaking change)
This is not breaking for Zygote. Its a nonbreaking feature to change what version of ChainRule's it supports
Good point, thanks. Yes, if Zygote bumps the compat and stops conjugating to/from ChainRules at the same time, this is not a breaking change. I have updated.
This issue tracks the necessary changes after https://github.com/JuliaDiff/ChainRulesCore.jl/issues/167 is merged:
ChainRulesCore.@scalar_rule
to conjugate the partials inrrule
. (breaking change) (https://github.com/JuliaDiff/ChainRulesCore.jl/pull/170)ChainRulesTestUtils.test_scalar
to conjugate the derivative when testingrrule
. (breaking change)(https://github.com/JuliaDiff/ChainRulesTestUtils.jl/pull/44)rrule
s to follow the new convention (breaking change).I have local implementations of most of these already.