JuliaDiff / ChainRules.jl

forward and reverse mode automatic differentiation primitives for Julia Base + StdLibs
Other
435 stars 89 forks source link

rrule for map #314

Open CarloLucibello opened 3 years ago

CarloLucibello commented 3 years ago

There used to be a rrule for map, introduced here https://github.com/JuliaDiff/ChainRules.jl/pull/56, but I can't find it anymore.

Related to https://github.com/FluxML/Zygote.jl/pull/842

gxyd commented 3 years ago

Using git bisect I can see that it was removed from system in commit: https://github.com/JuliaDiff/ChainRules.jl/commit/02e7857e34b5c01067a288262f69cfcb9fce069b

simeonschaub commented 3 years ago

See https://github.com/JuliaDiff/ChainRulesCore.jl/issues/68, we currently lack a proper way for rrules to call back into the AD system, so ChainRules can't really deal with higher-order functions yet.

nickrobinson251 commented 3 years ago

Xref https://github.com/JuliaDiff/ChainRules.jl/issues/222

oxinabox commented 3 years ago

222 is the version of this that we can without doing https://github.com/JuliaDiff/ChainRulesCore.jl/issues/68 first.

mzgubic commented 3 years ago

No longer blocked as of https://github.com/JuliaDiff/ChainRulesCore.jl/pull/363