search

JuliaDiff / ChainRulesCore.jl

AD-backend agnostic system defining custom forward and reverse mode rules. This is the light weight core to allow you to define rules for your functions in your packages, without depending on any particular AD system.
Other
249 stars 60 forks source link

typos in geometric descriptions in the docs #635

Open just-walk opened 9 months ago

just-walk commented 9 months ago

Unless I'm misunderstanding, it appears that "h" and "f" have been interchanged in the geometric description of the pushforward (Line 73 of propagators.md, specifically). If so, then that document could probably use someone knowledgeable to edit it for clarity. Even with some familiarity with differential geometry, the math is confusing. E.g. which functions are defined on what spaces.

oxinabox commented 9 months ago

The algebraic geometer who wrote that section no longer is involved in the project. It will take a bit to find someone knowledgable and interested.

sethaxen commented 9 months ago

Any of the Manifolds.jl devs could also review this text.

oxinabox commented 8 months ago

that would be appreciated, can you do so or ask someone to?