search

JuliaDiff / ChainRulesTestUtils.jl

Utilities for testing custom AD primitives.
MIT License
50 stars 15 forks source link

Remove test_approx ambig between Thunk and Tangent #245

Closed oxinabox closed 2 years ago

oxinabox commented 2 years ago

Should unblock https://github.com/JuliaDiff/ChainRulesCore.jl/pull/524#issuecomment-1074037647

Even if that PR isn't merged this is technically needed to get a good failure rather than a error when not matching

codecov-commenter commented 2 years ago

Codecov Report

Merging #245 (126d2b7) into main (05caea9) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   93.37%   93.41%   +0.03%     
==========================================
  Files          12       12              
  Lines         332      334       +2     
==========================================
+ Hits          310      312       +2     
  Misses         22       22
Impacted Files Coverage Δ
src/check_result.jl 90.00% <100.00%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05caea9...126d2b7. Read the comment docs.