Dispatch on StaticArray instead of SArray

JuliaDiff / DiffResults.jl

A package which provides an API for querying differentiation results at multiple orders simultaneously

http://juliadiff.org/DiffResults.jl/

Other

35 stars 11 forks source link

Dispatch on StaticArray instead of SArray #7

Closed devmotion closed 5 years ago

devmotion commented 5 years ago

Currently only SArrays are supported and no other StaticArrays such as SLArrays (https://github.com/JuliaDiffEq/LabelledArrays.jl). Together with a similar PR to ForwardDiff this seems to fix issues I experienced with SLArrays without breaking existing SArray support. However, since we do not dispatch on the mutability of the static arrays unfortunately even DiffResults for mutable static arrays such as MArray will be immutable.

coveralls commented 5 years ago

Coverage remained the same at 87.302% when pulling c7e6b0a960db92fb1c6b37ea6588d7bc38ef3ab7 on devmotion:staticarray into d49bd6d78c1f600bca237467b375941bb5a3caf8 on JuliaDiff:master.

coveralls commented 5 years ago

Coverage remained the same at 87.302% when pulling c7e6b0a960db92fb1c6b37ea6588d7bc38ef3ab7 on devmotion:staticarray into d49bd6d78c1f600bca237467b375941bb5a3caf8 on JuliaDiff:master.