search

JuliaDiff / DiffRules.jl

A simple shared suite of common derivative definitions
Other
74 stars 38 forks source link

Comment out trinary rules #60

Closed mcabbott closed 3 years ago

mcabbott commented 3 years ago

This removes the 3-argument rules introduced in https://github.com/JuliaDiff/DiffRules.jl/pull/54

While they appear to be explicitly supported by this package, they are violently rejected by ForwardDiff, it turns out.

According to https://github.com/SciML/ColPrac#accidental-breaking-releases the right path is to immediately tag a patch version without the problematic changes.

I have checked locally that ForwardDiff does load & run things, with this branch.

codecov-commenter commented 3 years ago

Codecov Report

Merging #60 (148b29c) into master (6c85048) will decrease coverage by 0.13%. The diff coverage is n/a.

:exclamation: Current head 148b29c differs from pull request most recent head 48e0478. Consider uploading reports for the commit 48e0478 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   94.07%   93.93%   -0.14%     
==========================================
  Files           2        2              
  Lines         135      132       -3     
==========================================
- Hits          127      124       -3     
  Misses          8        8
Impacted Files Coverage Δ
src/rules.jl 99.18% <ø> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c85048...48e0478. Read the comment docs.