search

JuliaDiff / DiffRules.jl

A simple shared suite of common derivative definitions
Other
74 stars 38 forks source link

Fix doctest failure #75

Closed cossio closed 2 years ago

cossio commented 2 years ago

The order in which DiffRules.diffrules() outputs things is not deterministic (because it depends on the order in which keys(..) returns things).

This means this jldoctest can fail:

julia> first(DiffRules.diffrules())
(:Base, :log2, 1)

Here we make it so that the output is deterministic.

cossio commented 2 years ago

The CI failures here might be related to the changes in Random in Julia 1.7?

codecov-commenter commented 2 years ago

Codecov Report

Merging #75 (05de036) into master (68cd4f2) will increase coverage by 1.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   94.66%   95.74%   +1.07%     
==========================================
  Files           2        2              
  Lines         150      141       -9     
==========================================
- Hits          142      135       -7     
+ Misses          8        6       -2
Impacted Files Coverage Δ
src/api.jl 54.54% <ø> (-10.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68cd4f2...05de036. Read the comment docs.

devmotion commented 2 years ago

Thanks for the fix @cossio!