search

JuliaDiff / DiffRules.jl

A simple shared suite of common derivative definitions
Other
75 stars 38 forks source link

Use FiniteDifferences in tests #80

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

I extracted this PR from https://github.com/JuliaDiff/DiffRules.jl/pull/79, I guess this makes it easier to review.

This PR replaces the custom and very basic forward finite differencing method in the tests with FiniteDifferences (e.g. also used by ChainRulesTestUtils). This allows us to lower the tolerances quite significantly which hopefully uncovers incorrect implementations more reliably.

codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (15948cf) into master (7b1c31e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files           3        3           
  Lines         165      165           
=======================================
  Hits          160      160           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b1c31e...15948cf. Read the comment docs.

devmotion commented 2 years ago

Fixed by https://github.com/JuliaDiff/DiffRules.jl/pull/55.