JuliaDiff / DiffRules.jl

A simple shared suite of common derivative definitions
Other
75 stars 38 forks source link

Support IrrationalConstants 0.2 #91

Closed devmotion closed 1 year ago

devmotion commented 1 year ago

IrrationalConstants 0.2 changes the type of the irrational constants to fix a type piracy issue: https://github.com/JuliaMath/IrrationalConstants.jl/pull/19 This change is breaking but should not cause any problems in DiffRules.

codecov-commenter commented 1 year ago

Codecov Report

Base: 97.31% // Head: 97.86% // Increases project coverage by +0.54% :tada:

Coverage data is based on head (ee06ba4) compared to base (9030629). Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #91 +/- ## ========================================== + Coverage 97.31% 97.86% +0.54% ========================================== Files 3 3 Lines 186 187 +1 ========================================== + Hits 181 183 +2 + Misses 5 4 -1 ``` | [Impacted Files](https://codecov.io/gh/JuliaDiff/DiffRules.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/api.jl](https://codecov.io/gh/JuliaDiff/DiffRules.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2FwaS5qbA==) | `88.23% <0.00%> (+3.38%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

devmotion commented 1 year ago

Test failures are unrelated and exist also on the master branch.

Not tested, new release of SpecialFunctions required first.