search

JuliaDiff / DualNumbers.jl

Julia package for representing dual numbers and for performing dual algebra
Other
80 stars 30 forks source link

added inline annotations #59

Open gasagna opened 7 years ago

gasagna commented 7 years ago

I have noticed consistent and significant speed ups (about 1.5x) in a largish private package by adding inline annotations to methods for +, -, /, * for dual numbers.

I have sprinkled @inline annotation around in other parts of the module to catch other use cases, but it might be too much.

mlubin commented 7 years ago

@gasagna, ForwardDiff already incorporates improvements like this and has additional speedups over DualNumbers thanks to chunking (https://arxiv.org/abs/1607.07892).

gasagna commented 7 years ago

Thanks. Any chance this will be merged or you reckon it is best to move to ForwardDiff as a dependency for my package?

mlubin commented 7 years ago

I'm willing to provide commit access if you (or somebody else) would like to take on some maintenance responsibility.

gasagna commented 7 years ago

Thanks, but I am not sure I want to step up as maintainer of this package :)

KristofferC commented 7 years ago

FWIW, 0.7 should make this PR not needed since the inlining heuristics are greatly improved. However, that doesn't help 0.6 so...

dkarrasch commented 1 year ago

I guess this can be closed?