Closed devmotion closed 1 year ago
Patch coverage has no change and project coverage change: +2.67
:tada:
Comparison is base (
2263749
) 86.98% compared to head (ea3a4b6
) 89.65%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Any idea why we'd see these test failures?
Not completely sure but I assume on Julia 1.9 it might just be due to different random numbers as only https://github.com/JuliaDiff/ForwardDiff.jl/actions/runs/5198679278/jobs/9375117936?pr=650#step:6:615 is failing. I don't know what's going on with nightly and the invalidations action.
I guess the test failures were indeed random, tests on Julia 1.9 passed successfully after rerunning them.
This PR adds the example in https://github.com/JuliaDiff/DiffRules.jl/pull/98#issuecomment-1574420052 as a test, to avoid that upstream reintroduces this bug (DiffRules runs downstream tests of ForwardDiff).