JuliaDiff / ForwardDiff.jl

Forward Mode Automatic Differentiation for Julia
Other
892 stars 145 forks source link

use oneunit, not one, to preserve type in single_seed #665

Open stevengj opened 1 year ago

stevengj commented 1 year ago

Fixes #651

This change is also required by #664, so if that PR is accepted then it supersedes this PR.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.07% :warning:

Comparison is base (d300209) 89.65% compared to head (1db2302) 86.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #665 +/- ## ========================================== - Coverage 89.65% 86.59% -3.07% ========================================== Files 11 10 -1 Lines 967 895 -72 ========================================== - Hits 867 775 -92 - Misses 100 120 +20 ``` | [Files Changed](https://app.codecov.io/gh/JuliaDiff/ForwardDiff.jl/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/partials.jl](https://app.codecov.io/gh/JuliaDiff/ForwardDiff.jl/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL3BhcnRpYWxzLmps) | `84.07% <100.00%> (-0.14%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/JuliaDiff/ForwardDiff.jl/pull/665/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.