Open timholy opened 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
d300209
) 89.65% compared to head (482dde0
) 87.41%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This checks whether
hypot
of the value component is zero, and if so switches to a next-order method.~This may be slightly controversial since it exploits the difference between 0.0 and -0.0 to give the correct sign behavior at the origin.~ This exploits the difference between 0.0 and -0.0 to provide the same behavior exhibited for
abs
:This implementation is consistent with the limit -> 0, e.g.,
Note this only covers the 3-arg version. For the 2-arg version I think a similar fix must be made in DiffRules.