search

JuliaDiff / ReverseDiff.jl

Reverse Mode Automatic Differentiation for Julia
Other
348 stars 57 forks source link

Add support for `AbstractArray{<:TrackedReal}` #169

Closed devmotion closed 3 years ago

devmotion commented 3 years ago

This is an alternative to https://github.com/JuliaDiff/ReverseDiff.jl/pull/164, as suggested by @mohamed82008. It fixes the example therein by adding support for AbstractArray{<:TrackedReal} instead of changing the output of view to TrackedArray instead of SubArray. Therefore it should add support for other array wrappers as well (untested).

mohamed82008 commented 3 years ago

If tests pass, I will merge and release.

codecov-io commented 3 years ago

Codecov Report

Merging #169 (47f400a) into master (d397cdf) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          18       18           
  Lines        1557     1557           
=======================================
  Hits         1284     1284           
  Misses        273      273
Impacted Files Coverage Δ
src/macros.jl 92.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d397cdf...47f400a. Read the comment docs.