Closed github-actions[bot] closed 4 years ago
DataStructures 0.18 now actually deprecated find_root
, so it might be preferable to drop support of DataStructures 0.17 and replace find_root
with find_root!
.
Handled by @kanav99
Still can do the drop of v0.17, but that won't be able to be tested for like a month so for now I'll just open an issue.
This pull request changes the compat entry for the
DataStructures
package from0.17
to0.17, 0.18
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.