search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

Remove numargs usage #166

Closed ChrisRackauckas closed 2 years ago

ChrisRackauckas commented 2 years ago

This just doesn't match the JuliaDiff style which is that the function call is defined by the function. I.e. out of place calls use out of place functions and in-place calls use in-place functions. This mixed it up which shouldn't be allowed in the API.

ChrisRackauckas commented 2 years ago

@avik-pal

codecov-commenter commented 2 years ago

Codecov Report

Merging #166 (dd09611) into master (25a276b) will increase coverage by 1.66%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   78.28%   79.94%   +1.66%     
==========================================
  Files          14       14              
  Lines         769      753      -16     
==========================================
  Hits          602      602              
+ Misses        167      151      -16
Impacted Files Coverage Δ
src/differentiation/vecjac_products.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a276b...dd09611. Read the comment docs.