search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

remove deprecated SparsityDetection #205

Closed ArnoStrouwen closed 1 year ago

ArnoStrouwen commented 1 year ago

Removes reliance on deprecated SparsityDetection.jl package.

A decision has to be made if we want to directly support sparsity detection here, through a small wrapper around the newer functionality in Symbolics.jl.

codecov-commenter commented 1 year ago

Codecov Report

Base: 81.40% // Head: 81.40% // No change to project coverage :thumbsup:

Coverage data is based on head (9b34e50) compared to base (e89cc31). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #205 +/- ## ======================================= Coverage 81.40% 81.40% ======================================= Files 15 15 Lines 898 898 ======================================= Hits 731 731 Misses 167 167 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ChrisRackauckas commented 1 year ago

Add the extra helper functions to Symbolics.jl, with some docs. It should really only be tested here.

ChrisRackauckas commented 1 year ago

Released, so try removing now