Closed vpuri3 closed 1 year ago
running CI with dummy change since tests were failing locally.
Patch coverage: 10.52
% and project coverage change: +0.10
:tada:
Comparison is base (
c2bbf98
) 0.21% compared to head (21a9a1e
) 0.31%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ChrisRackauckas looks like SparseDiffTools needs more comprehensive testing. I am getting arrayinerface errors with 1.9 on my personal machine that are not captured on CI.
Looks like package extension don't honor export statements. Rather, it is just
julia> versioninfo()
Julia Version 1.9.0-rc1
Commit 3b2e0d8fbc1 (2023-03-07 07:51 UTC)
(a) pkg> st
Status `~/.julia/dev/SparseDiffTools/a/Project.toml`
[47a9eef4] SparseDiffTools v2.0.0 `..`
[e88e6eb3] Zygote v0.6.56
julia> using SparseDiffTools, Zygote
[ Info: Precompiling SparseDiffToolsZygote [25f82377-10ae-5fb8-bc0d-27fd31de4285]
julia> m = Base.get_extension(SparseDiffTools, :SparseDiffToolsZygote)
SparseDiffToolsZygote
julia> m.ZygoteVecJac
ZygoteVecJac (generic function with 1 method)
julia> ZygoteVecJac
ERROR: UndefVarError: `ZygoteVecJac` not defined
julia> SparseDiffTools.ZygoteVecJac
ERROR: UndefVarError: `ZygoteVecJac` not defined
Stacktrace:
[1] getproperty(x::Module, f::Symbol)
So I think we should define and export these symbols in the main package, and write method definitions in the extension.
@ChrisRackauckas can you merge https://github.com/JuliaDiff/SparseDiffTools.jl/pull/220 so we can test for 1x9 here?
rerunning CI
@ChrisRackauckas good to go
part of https://github.com/JuliaDiff/SparseDiffTools.jl/issues/215
ref https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)