JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

overload Base.resize! #242

Closed vpuri3 closed 1 year ago

vpuri3 commented 1 year ago

fixes errrors in https://github.com/SciML/OrdinaryDiffEq.jl/pull/1917

merge https://github.com/JuliaDiff/SparseDiffTools.jl/pull/241 first.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 :tada:

Comparison is base (8d9a112) 84.76% compared to head (953afc3) 84.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #242 +/- ## ========================================== + Coverage 84.76% 84.95% +0.18% ========================================== Files 14 14 Lines 952 964 +12 ========================================== + Hits 807 819 +12 Misses 145 145 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/differentiation/jaches\_products.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2RpZmZlcmVudGlhdGlvbi9qYWNoZXNfcHJvZHVjdHMuamw=) | `95.53% <100.00%> (+0.15%)` | :arrow_up: | | [src/differentiation/vecjac\_products.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2RpZmZlcmVudGlhdGlvbi92ZWNqYWNfcHJvZHVjdHMuamw=) | `90.00% <100.00%> (+1.11%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ChrisRackauckas commented 1 year ago

Rebase this.

ChrisRackauckas commented 1 year ago

I rebased it for the diff. Looks good to go.

vpuri3 commented 1 year ago

awesome. thank you

vpuri3 commented 1 year ago

@ChrisRackauckas tests passed. Can you bump version after merging?