JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

Don't restrict the input type of matrix2graph unnecessarily #258

Closed avik-pal closed 10 months ago

avik-pal commented 10 months ago

This still won't work for CUSPARSE Arrays, we don't have findnz implemented, but in future if we define that this should be functional.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -31.71% :warning:

Comparison is base (1435e0b) 87.52% compared to head (140dfe3) 55.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #258 +/- ## =========================================== - Coverage 87.52% 55.81% -31.71% =========================================== Files 21 21 Lines 1178 1170 -8 =========================================== - Hits 1031 653 -378 - Misses 147 517 +370 ``` | [Files Changed](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/coloring/matrix2graph.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2NvbG9yaW5nL21hdHJpeDJncmFwaC5qbA==) | `100.00% <100.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/258/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.