JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

Fix Chunking #268

Closed avik-pal closed 8 months ago

avik-pal commented 8 months ago
codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b4b816b) 87.35% compared to head (e4581ec) 87.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #268 +/- ## ========================================== - Coverage 87.35% 87.34% -0.01% ========================================== Files 21 21 Lines 1234 1241 +7 ========================================== + Hits 1078 1084 +6 - Misses 156 157 +1 ``` | [Files](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [src/highlevel/coloring.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2hpZ2hsZXZlbC9jb2xvcmluZy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/highlevel/finite\_diff.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2hpZ2hsZXZlbC9maW5pdGVfZGlmZi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/highlevel/forward\_mode.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2hpZ2hsZXZlbC9mb3J3YXJkX21vZGUuamw=) | `100.00% <100.00%> (ø)` | | | [src/highlevel/reverse\_mode.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2hpZ2hsZXZlbC9yZXZlcnNlX21vZGUuamw=) | `100.00% <ø> (ø)` | | | [src/highlevel/common.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2hpZ2hsZXZlbC9jb21tb24uamw=) | `81.81% <83.33%> (+0.46%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 8 months ago
[OOP] [Immutable AD]: Error During Test at /home/runner/work/SparseDiffTools.jl/SparseDiffTools.jl/downstream/test/basictests.jl:482
 Unexpected Pass
 Expression: abs.(ForwardDiff.derivative((p->begin
                    (benchmark_nlsolve_oop(quadratic_f, #= /home/runner/work/SparseDiffTools.jl/SparseDiffTools.jl/downstream/test/basictests.jl:483 =# @SVector([1.0, 1.0]), p)).u[end]
                end), p)) ≈ 1 / (2 * sqrt(p))
 Got correct result, please change to @test if no longer broken.

That sounds good.