search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

Rework VecJac Operator #272

Closed avik-pal closed 8 months ago

avik-pal commented 8 months ago

~I will test with https://github.com/SciML/NonlinearSolve.jl/pull/268 a bit before merging~

codecov[bot] commented 8 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (7d23bec) 87.08% compared to head (635828a) 86.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #272 +/- ## ========================================== - Coverage 87.08% 86.62% -0.46% ========================================== Files 21 21 Lines 1254 1286 +32 ========================================== + Hits 1092 1114 +22 - Misses 162 172 +10 ``` | [Files](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff) | Coverage Δ | | |---|---|---| | [ext/SparseDiffToolsZygoteExt.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-ZXh0L1NwYXJzZURpZmZUb29sc1p5Z290ZUV4dC5qbA==) | `100.00% <100.00%> (+2.63%)` | :arrow_up: | | [src/differentiation/vecjac\_products.jl](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff#diff-c3JjL2RpZmZlcmVudGlhdGlvbi92ZWNqYWNfcHJvZHVjdHMuamw=) | `80.80% <75.00%> (-11.38%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaDiff/SparseDiffTools.jl/pull/272/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDiff)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 8 months ago

This might have to be a breaking change. The previous API dropped things and a lot of code was written to work around it. But now the API is more strict which breaks code :disappointed: