search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
240 stars 43 forks source link

Default to the older behavior #275

Closed avik-pal closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9a42b50) 86.82% compared to head (77a337a) 86.23%.

Files Patch % Lines
src/differentiation/common.jl 47.36% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== - Coverage 86.82% 86.23% -0.60% ========================================== Files 22 22 Lines 1283 1293 +10 ========================================== + Hits 1114 1115 +1 - Misses 169 178 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 10 months ago

Failures expected here. Fixed by https://github.com/SciML/OrdinaryDiffEq.jl/pull/2062 and https://github.com/SciML/NonlinearSolve.jl/pull/285. Once this and https://github.com/SciML/SciMLBase.jl/pull/543 are merged we can trigger those 2 CIs to confirm that things worked out

avik-pal commented 10 months ago

@ChrisRackauckas this can be merged