JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
240 stars 43 forks source link

More extensive use of Polyester #285

Closed avik-pal closed 7 months ago

avik-pal commented 7 months ago

Tests were already present -- they just took the ForwardDiff fallback.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (01a5e5f) 85.25% compared to head (9fa3444) 84.34%.

Files Patch % Lines
ext/SparseDiffToolsPolyesterForwardDiffExt.jl 51.85% 13 Missing :warning:
ext/SparseDiffToolsPolyesterExt.jl 75.00% 11 Missing :warning:
src/highlevel/coloring.jl 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #285 +/- ## ========================================== - Coverage 85.25% 84.34% -0.91% ========================================== Files 23 24 +1 Lines 1404 1476 +72 ========================================== + Hits 1197 1245 +48 - Misses 207 231 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 7 months ago

Holding off on the polyester version for in place version. Maybe someone more versed in polyester can get it working

avik-pal commented 7 months ago

cc @ChrisRackauckas

avik-pal commented 7 months ago

@ChrisRackauckas you will have to merge and register