Closed gdalle closed 2 months ago
Attention: Patch coverage is 0%
with 57 lines
in your changes are missing coverage. Please review.
Project coverage is 0.06%. Comparing base (
a96de04
) to head (1365d5e
). Report is 2 commits behind head on master.:exclamation: Current head 1365d5e differs from pull request most recent head 6f001e2. Consider uploading reports for the commit 6f001e2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ChrisRackauckas this is ready for a first pass. Not sure if the missed lines in Codecov are my fault or not.
Looks good!
Upgrade ADTypes to v1.0 for the sparse backend types only (nothing yet about the coloring and sparsity detection infrastructure).
Supersedes #294
Main changes
AutoSparseForwardDiff(...)
(construction) withAutoSparse(AutoForwardDiff(...))
AutoSparseForwardDiff
(dispatch) withAutoSparse{<:AutoForwardDiff}
(be careful with type parameters like{C}
)AutoSparseEnzyme
anymoresparse_jacobian_cache(ad, args...; kwargs...) = sparse_jacobian_cache_aux(mode(ad), ad, args...; kwargs...)
. Add implem forForwardOrReverseMode
which checks if we're dealing withDiffractor
orEnzyme
(not hit by tests for some reason :thinking:)_get_colorvec(alg, ad)
with_get_colorvec(alg, mode(ad))
Questions