search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
242 stars 42 forks source link

Remove Tricks #308

Closed oscardssmith closed 1 month ago

oscardssmith commented 1 month ago

Tricks are for kids!

(and since Julia 1.10, static_hasmethod is just hasmethod)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (4e36edd) to head (4601a51). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/differentiation/common.jl 50.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #308 +/- ## ========================================== + Coverage 83.16% 83.43% +0.26% ========================================== Files 25 25 Lines 1491 1491 ========================================== + Hits 1240 1244 +4 + Misses 251 247 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 1 month ago

@wsmoses are you aware of these Enzyme breaks on v1.11? https://github.com/JuliaDiff/SparseDiffTools.jl/actions/runs/11263597921/job/31321830996?pr=308#step:6:3704