JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
242 stars 42 forks source link

Added acyclic coloring #60

Closed pkj-m closed 5 years ago

pkj-m commented 5 years ago

Allows user to color graph using acyclic coloring algorithm. The main difference between acyclic coloring and ordinary distance-1 coloring is that in the case of acyclic coloring, on top of the regular distance-1 coloring condition, there is an added condition that all the cycles in the graph have atleast 3 colors present.

Example to illustrate the difference: a6d1589c-4600-4d7e-9a4c-958ef9995943

TODO:

29

matbesancon commented 5 years ago

I want to approve this PR just for the artistic drawings, but I'll restrain myself

ChrisRackauckas commented 5 years ago

Those renderings, A+.

matbesancon commented 5 years ago

@pkj-m to be ~a pain in the~ detailed-oriented, I'd advise putting all functions and variables in snake_case, not camelCase as mergeTrees and forbiddenColors

matbesancon commented 5 years ago

@pkj-m some few more comments, then it looks good

pkj-m commented 5 years ago

@ChrisRackauckas @matbesancon can we merge this now?

matbesancon commented 5 years ago

Good to me yes

On Mon, Aug 26, 2019, 21:44 Pankaj Mishra notifications@github.com wrote:

@ChrisRackauckas https://github.com/ChrisRackauckas @matbesancon https://github.com/matbesancon can we merge this now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaDiffEq/SparseDiffTools.jl/pull/60?email_source=notifications&email_token=AB2FDMXC2FVUCTF3YYTVYUDQGQXAPA5CNFSM4IJ3RQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FOONY#issuecomment-525002551, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2FDMWBEJ4GIJP24PNKGB3QGQXAPANCNFSM4IJ3RQTA .