search

JuliaDiff / SparseDiffTools.jl

Fast jacobian computation through sparsity exploitation and matrix coloring
MIT License
237 stars 41 forks source link

Default row argument for graph creation, removing debug lines #97

Closed matbesancon closed 4 years ago

matbesancon commented 4 years ago

Fixes #86

matbesancon commented 4 years ago

also @ChrisRackauckas I don't have the rights on the repo anymore with the change of org

matbesancon commented 4 years ago

https://travis-ci.org/github/JuliaDiff/SparseDiffTools.jl/builds/669186261 The plot thickens, an error with 1.3 on mac only

matbesancon commented 4 years ago

ok finally passing. @ChrisRackauckas good to merge here

matbesancon commented 4 years ago

It was the default before adding the option

On Fri, May 1, 2020, 17:38 Christopher Rackauckas notifications@github.com wrote:

@ChrisRackauckas commented on this pull request.

In src/coloring/matrix2graph.jl https://github.com/JuliaDiff/SparseDiffTools.jl/pull/97#discussion_r418623467 :

A utility function to generate a graph from input sparse matrix, columns are represented with vertices and 2 vertices are connected with an edge only if the two columns are mutually orthogonal. """ -function matrix2graph(sparse_matrix::SparseMatrixCSC{<:Number, Int}, partition_by_rows::Bool) +function matrix2graph(sparse_matrix::SparseMatrixCSC{<:Number, Int}, partition_by_rows::Bool=true)

why default to rows?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JuliaDiff/SparseDiffTools.jl/pull/97#pullrequestreview-404261816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2FDMQWUNJYEST4PLCUDBTRPL3GXANCNFSM4LXM5CZQ .

ChrisRackauckas commented 4 years ago

oh yes, partitioning by rows is Forward mode.