search

JuliaDiffusionBayes / GuidedProposals.jl

Implementation of Guided Proposals (introduced by M Schauer, F van der Meulen, H van Zanten)
MIT License
1 stars 0 forks source link

time change #2

Closed fmeulen closed 4 years ago

fmeulen commented 4 years ago

The doc is incorrect for standard_guid_prop_time_transf(tt).

the transformation should be t0 + (t-t0) (2-(t-t0)/(T-t0)) as is (correctly) implemented

mmider commented 4 years ago

~I can't see the problem in the docs. It seems to me that the implementation and the docs agree... What should be changed~

Edit: sorry, I am blind, found it, I will change it with the next push.

fmeulen commented 4 years ago

the “2-“ should not be in the numerator (Just plug in t=T, then one should get T, right?)

Frank van der Meulen Delft University of Technology http://dutiosb.twi.tudelft.nl/~meulen/

On 26 Jun 2020, at 15.01, Marcin Mider notifications@github.com<mailto:notifications@github.com> wrote:

I can't see the problem in the docshttps://urldefense.proofpoint.com/v2/url?u=https-3A__juliadiffusionbayes.github.io_GuidedProposals.jl_dev_module-5Findex_-23GuidedProposals.standard-5Fguid-5Fprop-5Ftime-5Ftransf-2DTuple-257BAny-257D&d=DwMCaQ&c=XYzUhXBD2cD-CornpT4QE19xOJBbRy-TBPLK0X9U2o8&r=7iF-JNHl-g2k0SDAFdfpFNwTGT5g4T8E90C3u4ODfF8&m=4vAe-zGs6jfQphNl5qgnVktTiWiQc6KQmtkcTNij6Tc&s=aqqxvntf4KFJv9NbRoynelgUkgUa3M0Yb0q4vyFCkAs&e=. It seems to me that the implementation and the docs agree... What should be changed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JuliaDiffusionBayes_GuidedProposals.jl_issues_2-23issuecomment-2D650166126&d=DwMCaQ&c=XYzUhXBD2cD-CornpT4QE19xOJBbRy-TBPLK0X9U2o8&r=7iF-JNHl-g2k0SDAFdfpFNwTGT5g4T8E90C3u4ODfF8&m=4vAe-zGs6jfQphNl5qgnVktTiWiQc6KQmtkcTNij6Tc&s=jkK7ISKvxb6mgixrnvSaeHDHFKsSh1FN5ukFFIWlo1w&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJTTG33CUC5WJLN3JW4JSV3RYSLZTANCNFSM4OJJQNBA&d=DwMCaQ&c=XYzUhXBD2cD-CornpT4QE19xOJBbRy-TBPLK0X9U2o8&r=7iF-JNHl-g2k0SDAFdfpFNwTGT5g4T8E90C3u4ODfF8&m=4vAe-zGs6jfQphNl5qgnVktTiWiQc6KQmtkcTNij6Tc&s=FYDQ2hfeK9z9WOVOQSHsKCkI6UncKrsts6-4REs32hM&e=.

mmider commented 4 years ago

Thanks, I realized right after I sent a message and I edited my response accordingly on github. The edits are not sent to email.

mmider commented 4 years ago

56477ad