The cover image was not properly handled when using a relative path

JuliaDocs / DemoCards.jl

Let's focus on writing demos

MIT License

65 stars 14 forks source link

The cover image was not properly handled when using a relative path #146

Open TCLiuu opened 1 year ago

TCLiuu commented 1 year ago

When the image path referenced in the example is a relative path, it cannot be processed correctly. For example,

![](../figures/cover.png)

Will produce an error, and the result will be like

┌ Warning: cover file doesn't exists
│   cover_path = "<CARD_PATH>/../figures/cover.png"
└ @ DemoCards ~/.julia/packages/DemoCards/ZgH8l/src/generate.jl:358

I think the problem arises from https://github.com/JuliaDocs/DemoCards.jl/blob/53ac68a4caafc62b5e02ddf5817204d26d2e8d00/src/generate.jl#L356

frankier commented 10 months ago

This report is a bit unclear. Does cover_path really exist on your system? Does it print literally "" or is that your own replacement?