Add possibility of specifying fallback_cover

JuliaDocs / DemoCards.jl

Let's focus on writing demos

MIT License

65 stars 14 forks source link

Add possibility of specifying fallback_cover #150

Closed frankier closed 8 months ago

frankier commented 10 months ago

(PR currently broken)

It would be nice to be able to specify other fallback images since as you mentioned in https://github.com/JuliaDocs/DemoCards.jl/pull/131 the default might not always be suitable.

Would it be reasonable to specify this using properties? Then it could be overridden at different levels? In this case, where should paths be relative to? If you are +1 on the idea and help resolve these questions I will fix up this PR.

johnnychen94 commented 10 months ago

Hi @frankier, I'm sorry I don't have the bandwidth recently to proceed with the Open-Source repos. But I also don't want to let you wait for my reviews infinitely.

I just gave you the write permission so that you can commit whatever features you like if you're confident.

frankier commented 10 months ago

Very understandable. Thanks! I will use it responsibly.